Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ft-input keyboard naviagation #2943

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Fix ft-input keyboard naviagation #2943

merged 1 commit into from
Dec 13, 2022

Conversation

ChunkyProgrammer
Copy link
Member

Fix keyboard navigation for input lists (search + setting invidious instance)

Pull Request Typ

  • Bugfix

Related issue

closes #2708

Description

No longer set the input value on arrow keys (this is an accessibility enhancement)

Testing

  • Use arrow keys to navigate search suggestions + invidious instance
  • Click enter to set instance

Desktop

  • OS: Windows
  • OS Version: 11
  • FreeTube version: 0.18.0

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 12, 2022
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 12, 2022 01:58
PikachuEXE
PikachuEXE approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Invidious selector & navbar search input

@absidue
Copy link
Member

absidue commented Dec 12, 2022

using this pr in the search bar, pressing enter searches with the selected auto complete option, i would expect it to auto complete it into the search bar, or maybe tab should do that?

@ChunkyProgrammer
Copy link
Member Author

using this pr in the search bar, pressing enter searches with the selected auto complete option, i would expect it to auto complete it into the search bar, or maybe tab should do that?

I'm not sure what you mean

@absidue
Copy link
Member

absidue commented Dec 12, 2022

okay i'll make up an example as a usecase, let's say I started typing comp and there was a suggestion for computer but as I want to search for computer test, i want it to put the computer suggestion into the search bar, but let me keep typing so I can write the rest. currently there is no way to do that. Although YouTube seems to behave the same way so I guess it's fine.

@FreeTubeBot FreeTubeBot merged commit c6e4221 into FreeTubeApp:development Dec 13, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 13, 2022
@ChunkyProgrammer ChunkyProgrammer mentioned this pull request Dec 13, 2022
Merged
1 task
@PikachuEXE PikachuEXE mentioned this pull request Dec 15, 2022
Merged
4 tasks
@PikachuEXE PikachuEXE mentioned this pull request Jan 24, 2023
Merged
4 tasks
@ChunkyProgrammer ChunkyProgrammer deleted the fix-keyboard-notiication-on-ft-input branch July 12, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Going through list in search is broken
5 participants
@ChunkyProgrammer @absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @FreeTubeBot